Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(op): allow scope without openid #613

Merged
merged 1 commit into from
Jun 13, 2024
Merged

feat(op): allow scope without openid #613

merged 1 commit into from
Jun 13, 2024

Conversation

muhlemmer
Copy link
Collaborator

@muhlemmer muhlemmer commented Jun 12, 2024 •
edited
Loading

This changes removes the requirement of the openid scope to be set for all token requests.
As this library also support OAuth2-only authentication mechanisms we still want to sanitize requested scopes, but not enforce the openid scope.

Related to zitadel/zitadel#8068

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

@muhlemmer
feat(op): allow scope without openid
0c14307 
This changes removes the requirement of the openid scope to be set for all token requests.
As this library also support OAuth2-only authentication mechanisms we still want to sanitize requested scopes, but not enforce the openid scope.

Related to zitadel/zitadel#8068
@muhlemmer muhlemmer marked this pull request as ready for review June 12, 2024 09:54
@muhlemmer muhlemmer requested a review from livio-a June 12, 2024 09:54
@muhlemmer muhlemmer enabled auto-merge (squash) June 12, 2024 09:55
muhlemmer added a commit to zitadel/zitadel that referenced this pull request Jun 12, 2024
@muhlemmer
chore(oidc): upgrade zitadel/oidc
fac481a 
This change upgrades the oidc package to include zitadel/oidc#613.
This will drop the requirement of the `openid` scope in all auth and token request types.
@muhlemmer muhlemmer mentioned this pull request Jun 12, 2024
Merged
@muhlemmer muhlemmer merged commit a7b5355 into main Jun 13, 2024
6 checks passed
@muhlemmer muhlemmer deleted the feat-openid-scope branch June 13, 2024 06:16
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 3.25.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

muhlemmer added a commit to zitadel/zitadel that referenced this pull request Jun 13, 2024
@muhlemmer
fix(oidc): upgrade zitadel/oidc to allow scope without openid (#8109)
81cc7c6 
# Which Problems Are Solved

Drop the requirement of the `openid` scope in all auth and token request
types.

# How the Problems Are Solved

This change upgrades the oidc package to include
zitadel/oidc#613.

# Additional Changes

- Fix a typo in a go doc string
- upgrade otel modules to match the version from oidc.

# Additional Context

- #7822 started doing scope
validation for machine user authentication on the token endpoint.
- #8068 reports breakage
of machine authentication without `openid` scope.
- Merge after zitadel/oidc#613 is released.
livio-a pushed a commit to zitadel/zitadel that referenced this pull request Jun 13, 2024
@muhlemmer @livio-a
fix(oidc): upgrade zitadel/oidc to allow scope without openid (#8109)
869ebce 
# Which Problems Are Solved

Drop the requirement of the `openid` scope in all auth and token request
types.

# How the Problems Are Solved

This change upgrades the oidc package to include
zitadel/oidc#613.

# Additional Changes

- Fix a typo in a go doc string
- upgrade otel modules to match the version from oidc.

# Additional Context

- #7822 started doing scope
validation for machine user authentication on the token endpoint.
- #8068 reports breakage
of machine authentication without `openid` scope.
- Merge after zitadel/oidc#613 is released.

(cherry picked from commit 81cc7c6)
livio-a pushed a commit to zitadel/zitadel that referenced this pull request Jun 13, 2024
@muhlemmer @livio-a
fix(oidc): upgrade zitadel/oidc to allow scope without openid (#8109)
6fef942 
# Which Problems Are Solved

Drop the requirement of the `openid` scope in all auth and token request
types.

# How the Problems Are Solved

This change upgrades the oidc package to include
zitadel/oidc#613.

# Additional Changes

- Fix a typo in a go doc string
- upgrade otel modules to match the version from oidc.

# Additional Context

- #7822 started doing scope
validation for machine user authentication on the token endpoint.
- #8068 reports breakage
of machine authentication without `openid` scope.
- Merge after zitadel/oidc#613 is released.

(cherry picked from commit 81cc7c6)
livio-a pushed a commit to zitadel/zitadel that referenced this pull request Jun 21, 2024
@muhlemmer @livio-a
fix(oidc): upgrade zitadel/oidc to allow scope without openid (#8109)
c2d53ca 
# Which Problems Are Solved

Drop the requirement of the `openid` scope in all auth and token request
types.

# How the Problems Are Solved

This change upgrades the oidc package to include
zitadel/oidc#613.

# Additional Changes

- Fix a typo in a go doc string
- upgrade otel modules to match the version from oidc.

# Additional Context

- #7822 started doing scope
validation for machine user authentication on the token endpoint.
- #8068 reports breakage
of machine authentication without `openid` scope.
- Merge after zitadel/oidc#613 is released.
brandonkal pushed a commit to brandonkal/zitadel that referenced this pull request Jun 26, 2024
@muhlemmer @brandonkal
fix(oidc): upgrade zitadel/oidc to allow scope without openid (zitade…
aa88526 
…l#8109)

# Which Problems Are Solved

Drop the requirement of the `openid` scope in all auth and token request
types.

# How the Problems Are Solved

This change upgrades the oidc package to include
zitadel/oidc#613.

# Additional Changes

- Fix a typo in a go doc string
- upgrade otel modules to match the version from oidc.

# Additional Context

- zitadel#7822 started doing scope
validation for machine user authentication on the token endpoint.
- zitadel#8068 reports breakage
of machine authentication without `openid` scope.
- Merge after zitadel/oidc#613 is released.
RedstonePfalz pushed a commit to RedstonePfalz/zitadel that referenced this pull request Jul 22, 2024
@muhlemmer @RedstonePfalz
fix(oidc): upgrade zitadel/oidc to allow scope without openid (zitade…
97b766f 
…l#8109)

# Which Problems Are Solved

Drop the requirement of the `openid` scope in all auth and token request
types.

# How the Problems Are Solved

This change upgrades the oidc package to include
zitadel/oidc#613.

# Additional Changes

- Fix a typo in a go doc string
- upgrade otel modules to match the version from oidc.

# Additional Context

- zitadel#7822 started doing scope
validation for machine user authentication on the token endpoint.
- zitadel#8068 reports breakage
of machine authentication without `openid` scope.
- Merge after zitadel/oidc#613 is released.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@livio-a livio-a livio-a approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@muhlemmer @livio-a